GroveEngine/tests/modules/TestModule.cpp
StillHammer aa322d5214 fix: Correct hot-reload version validation in race condition test
Fixed critical bug where moduleVersion was being overwritten during
setConfiguration(), preventing proper hot-reload validation.

## Problem
- TestModule::setConfiguration() called configNode.getString("version")
- This overwrote the compiled moduleVersion (v2, v3, etc.) back to "v1"
- All reloads appeared successful but versions never actually changed
- Test validated thread safety but NOT actual hot-reload functionality

## Solution
- Removed moduleVersion overwrite from setConfiguration()
- moduleVersion now preserved as global compiled into .so
- Added clear comments explaining this is a compile-time value
- Simplified test configuration (no longer passes version param)

## Test Results (After Fix)
 15/15 compilations (100%)
 29/29 reloads (100%)
 Versions actually change: v1 → v2 → v5 → v14 → v15
 0 corruptions
 0 crashes
 330ms avg reload time (file stability check working)
 Test now validates REAL hot-reload, not just thread safety

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-15 13:21:57 +08:00

123 lines
3.7 KiB
C++

#include <grove/IModule.h>
#include <grove/JsonDataNode.h>
#include <grove/JsonDataValue.h>
#include <iostream>
#include <memory>
// This line will be modified by AutoCompiler during race condition tests
std::string moduleVersion = "v1";
namespace grove {
/**
* @brief Simple test module for hot-reload validation
*
* This module demonstrates:
* - State preservation across reloads
* - IDataNode-based configuration
* - Simple counter logic
*/
class TestModule : public IModule {
private:
int counter = 0;
IIO* io = nullptr;
ITaskScheduler* scheduler = nullptr;
std::unique_ptr<IDataNode> config;
public:
TestModule() {
std::cout << "[TestModule] Constructor called - " << moduleVersion << std::endl;
}
~TestModule() override {
std::cout << "[TestModule] Destructor called" << std::endl;
}
void process(const IDataNode& input) override {
counter++;
std::cout << "[TestModule] Process #" << counter
<< " - Version: " << moduleVersion << std::endl;
// Print input if available
std::string message = input.getString("message", "");
if (!message.empty()) {
std::cout << "[TestModule] Received message: " << message << std::endl;
}
}
void setConfiguration(const IDataNode& configNode, IIO* ioPtr, ITaskScheduler* schedulerPtr) override {
std::cout << "[TestModule] Configuration set" << std::endl;
this->io = ioPtr;
this->scheduler = schedulerPtr;
// Clone configuration for storage
config = std::make_unique<JsonDataNode>("config", nlohmann::json::object());
// Note: moduleVersion is a global compiled into the .so file
// We DO NOT overwrite it from config to preserve hot-reload version changes
std::cout << "[TestModule] Compiled version: " << moduleVersion << std::endl;
}
const IDataNode& getConfiguration() override {
if (!config) {
config = std::make_unique<JsonDataNode>("config", nlohmann::json::object());
}
return *config;
}
std::unique_ptr<IDataNode> getHealthStatus() override {
nlohmann::json health = {
{"status", "healthy"},
{"counter", counter},
{"version", moduleVersion}
};
return std::make_unique<JsonDataNode>("health", health);
}
void shutdown() override {
std::cout << "[TestModule] Shutdown called - Counter at: " << counter << std::endl;
}
std::unique_ptr<IDataNode> getState() override {
std::cout << "[TestModule] getState() - Saving counter: " << counter << std::endl;
nlohmann::json state = {
{"counter", counter},
{"version", moduleVersion}
};
return std::make_unique<JsonDataNode>("state", state);
}
void setState(const IDataNode& state) override {
counter = state.getInt("counter", 0);
std::cout << "[TestModule] setState() - Restored counter: " << counter << std::endl;
std::string oldVersion = state.getString("version", "unknown");
std::cout << "[TestModule] setState() - Previous version was: " << oldVersion << std::endl;
}
std::string getType() const override {
return "TestModule";
}
bool isIdle() const override {
// TestModule has no async operations, always idle
return true;
}
};
} // namespace grove
// Module factory function - required for dynamic loading
extern "C" {
grove::IModule* createModule() {
return new grove::TestModule();
}
void destroyModule(grove::IModule* module) {
delete module;
}
}