StillHammer/GroveEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
master
GroveEngine/tests/integration
History
StillHammer 1b7703f07b feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 
## Breaking Change

IIO API redesigned from manual pull+if-forest to callback dispatch.
All modules must update their subscribe() calls to pass handlers.

### Before (OLD API)
```cpp
io->subscribe("input:mouse");

void process(...) {
    while (io->hasMessages()) {
        auto msg = io->pullMessage();
        if (msg.topic == "input:mouse") {
            handleMouse(msg);
        } else if (msg.topic == "input:keyboard") {
            handleKeyboard(msg);
        }
    }
}
```

### After (NEW API)
```cpp
io->subscribe("input:mouse", [this](const Message& msg) {
    handleMouse(msg);
});

void process(...) {
    while (io->hasMessages()) {
        io->pullAndDispatch();  // Callbacks invoked automatically
    }
}
```

## Changes

**Core API (include/grove/IIO.h)**
- Added: `using MessageHandler = std::function<void(const Message&)>`
- Changed: `subscribe()` now requires `MessageHandler` callback parameter
- Changed: `subscribeLowFreq()` now requires `MessageHandler` callback
- Removed: `pullMessage()`
- Added: `pullAndDispatch()` - pulls and auto-dispatches to handlers

**Implementation (src/IntraIO.cpp)**
- Store callbacks in `Subscription.handler`
- `pullAndDispatch()` matches topic against ALL subscriptions (not just first)
- Fixed: Regex pattern compilation supports both wildcards (*) and regex (.*)
- Performance: ~1000 msg/s throughput (unchanged from before)

**Files Updated**
- 31 test/module files migrated to callback API (via parallel agents)
- 8 documentation files updated (DEVELOPER_GUIDE, USER_GUIDE, module READMEs)

## Bugs Fixed During Migration

1. **pullAndDispatch() early return bug**: Was only calling FIRST matching handler
   - Fix: Loop through ALL subscriptions, invoke all matching handlers

2. **Regex pattern compilation bug**: Pattern "player:.*" failed to match
   - Fix: Detect ".*" in pattern → use as regex, otherwise escape and convert wildcards

## Testing

✅ test_11_io_system: PASSED (IIO pub/sub, pattern matching, batching)
✅ test_threaded_module_system: 6/6 PASSED
✅ test_threaded_stress: 5/5 PASSED (50 modules, 100x reload, concurrent ops)
✅ test_12_datanode: PASSED
✅ 10 TopicTree scenarios: 10/10 PASSED
✅ benchmark_e2e: ~1000 msg/s throughput

Total: 23+ tests passing

## Performance Impact

No performance regression from callback dispatch:
- IIO throughput: ~1000 msg/s (same as before)
- ThreadedModuleSystem: Speedup ~1.0x (barrier pattern expected)

## Migration Guide

For all modules using IIO:

1. Update subscribe() calls to include handler lambda
2. Replace pullMessage() loops with pullAndDispatch()
3. Move topic-specific logic from if-forest into callbacks

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-19 14:19:27 +07:00
..
IT_014_ui_module_integration.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
IT_015_input_ui_integration_minimal.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
IT_015_input_ui_integration.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
IT_015_input_ui_integration.cpp.backup Migration Gitea 2025-12-04 20:15:53 +08:00
IT_015_STATUS.md Migration Gitea 2025-12-04 20:15:53 +08:00
test_01_production_hotreload.cpp fix: IntraIOManager batch thread + AutoCompiler Windows support 2025-12-31 09:44:37 +07:00
test_02_chaos_monkey.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_03_stress_test.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_04_race_condition.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_05_memory_leak.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_06_error_recovery.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_07_limits.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_08_config_hotreload.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_09_module_dependencies.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_10_multiversion_coexistence.cpp fix: Windows MinGW CTest compatibility - DLL loading and module paths 2025-12-30 20:04:44 +07:00
test_11_io_system.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
test_12_datanode.cpp feat: Add Scenario 11 IO System test & fix IntraIO routing architecture 2025-11-19 11:43:08 +08:00
test_13_cross_system.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
test_20_bgfx_rhi.cpp feat(BgfxRenderer): Phase 5.5 - Sprite shader with instancing and texture support 2025-11-27 19:27:25 +08:00
test_22_bgfx_sprites_headless.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
test_logger_threadsafe.cpp fix: Critical race conditions in ThreadedModuleSystem and logger 2026-01-19 07:37:31 +07:00
test_pipeline_headless.cpp feat: Complete Phase 6.5 - Comprehensive BgfxRenderer testing 2025-11-29 22:56:29 +08:00
test_resource_cache.cpp feat: Complete Phase 6.5 - Comprehensive BgfxRenderer testing 2025-11-29 22:56:29 +08:00
test_scene_collector.cpp feat: Complete Phase 6.5 - Comprehensive BgfxRenderer testing 2025-11-29 22:56:29 +08:00
test_texture_loader.cpp feat: Complete Phase 6.5 - Comprehensive BgfxRenderer testing 2025-11-29 22:56:29 +08:00
test_threaded_module_system.cpp fix: Critical race conditions in ThreadedModuleSystem and logger 2026-01-19 07:37:31 +07:00
test_threaded_real_modules.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
test_threaded_simple_real.cpp feat(IIO)!: BREAKING CHANGE - Callback-based message dispatch 2026-01-19 14:19:27 +07:00
test_threaded_stress.cpp fix: Critical race conditions in ThreadedModuleSystem and logger 2026-01-19 07:37:31 +07:00